Skip to content

Fix vec iter zst alignment 148682 #149272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix vec iter zst alignment 148682 #149272

wants to merge 9 commits into from
+16 −2

Conversation

@DrAsu33
Copy link

@DrAsu33 DrAsu33 commented Nov 24, 2025

No description provided.

@DrAsu33
Fix dropping elements for zero-sized types in IntoIter
ba9a8d9 
Handle zero-sized types (ZST) to prevent unalignment issues when dropping elements.
@DrAsu33
Add test for nth_back with high alignment ZST
32ddf5e 
Test that Intolter::nth_back does not cause UB for ZSTs with high alignment.
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@DrAsu33
Correct pointer creation for zero-sized types
4e34457 
Fix incorrect usage of step_size in pointer creation for ZST.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
reddevilmidzy
reddevilmidzy reviewed Nov 24, 2025
View reviewed changes
tests/ui/issues/issue-zst-nthback-148682.rs
Copy link
Contributor

@reddevilmidzy reddevilmidzy Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the file name needs to be changed.

https://rustc-dev-guide.rust-lang.org/tests/best-practices.html#test-naming

Copy link
Contributor

@reddevilmidzy reddevilmidzy Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the issues directory, please refer to this and choose a more appropriate location.

reddevilmidzy
reddevilmidzy reviewed Nov 24, 2025
View reviewed changes
tests/ui/issues/issue-148682.rs Outdated
@@ -0,0 +1,9 @@
// check-pass
Copy link
Contributor

@reddevilmidzy reddevilmidzy Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// check-pass
//@ check-pass

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kivooeo
Copy link
Member

Kivooeo commented Nov 24, 2025

r? libs

@rustbot rustbot assigned Mark-Simulacrum and unassigned fee1-dead Nov 24, 2025
@Kivooeo Kivooeo added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2025
@DrAsu33
Copy link
Author

DrAsu33 commented Nov 25, 2025

@reddevilmidzy Thanks! Updated as requested.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
reddevilmidzy
reddevilmidzy reviewed Nov 25, 2025
View reviewed changes
Copy link
Contributor

@reddevilmidzy reddevilmidzy left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please squash

View changes since this review

tests/ui/issues/issue-zst-nthback-148682.rs Outdated
Comment on lines 1 to 2
// @ check-pass
//test Intolter::nth_back does not cause UB for ZSTs with high alignment
Copy link
Contributor

@reddevilmidzy reddevilmidzy Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove leading spaces from commands, and add a space before comments.

Suggested change
// @ check-pass
//test Intolter::nth_back does not cause UB for ZSTs with high alignment
//@ check-pass
// test Intolter::nth_back does not cause UB for ZSTs with high alignment

Copy link
Author

@DrAsu33 DrAsu33 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！It seems that all the CI tests are passed

tests/ui/issues/issue-zst-nthback-148682.rs
Copy link
Contributor

@reddevilmidzy reddevilmidzy Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the issues directory, please refer to this and choose a more appropriate location.

chenyukang
chenyukang reviewed Nov 25, 2025
View reviewed changes
@DrAsu33 @chenyukang
Update library/alloc/src/vec/into_iter.rs
ceb3c6f 
Co-authored-by: Yukang <moorekang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyukang chenyukang chenyukang left review comments

+1 more reviewer

@reddevilmidzy reddevilmidzy reddevilmidzy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@DrAsu33 @rustbot @rust-log-analyzer @Kivooeo @chenyukang @reddevilmidzy @Mark-Simulacrum @fee1-dead